Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove smart_open requirement #13391

Merged
merged 1 commit into from
Mar 22, 2024
Merged

remove smart_open requirement #13391

merged 1 commit into from
Mar 22, 2024

Conversation

svlandeg
Copy link
Member

Description

spaCy doesn't need to manage the smart_open requirement, as this is taken care of by Weasel.

Related PR to bump smart_open to the latest version: explosion/weasel#84

Types of change

fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the enhancement Feature requests and improvements label Mar 22, 2024
@svlandeg svlandeg merged commit d410d95 into explosion:master Mar 22, 2024
13 checks passed
@svlandeg svlandeg deleted the feature/bump_smartopen branch March 22, 2024 17:21
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 29, 2024
@jikanter
remove smart_open requirement as it's taken care of via Weasel (explo…
3c564f9 
…sion#13391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Feature requests and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@svlandeg